Vinagar won't harm the tank
But it won't slow down the damage caused by urine either. Sooner or later you will have to replace it, 'cuz on average any metal--even 316 stainless--tank will start to leak at a seam or a fitting within 2-5 years and turn into a collander in about 10. When it does start to leak, it won't be a catastrophic failure, just some slight weeping that Marine Tex should stop long enough to get you through the rest of the season. I'd wait till that happens before replacing it. Or, if you have to replace hoses before it starts to leak, do it then, 'cuz rehosing is the worst part of the job.